Enable this to build with build isolation on #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed you mentioned: But i believe if you already have torch, because there's no version specified in the build requirement, it will just use whatever is in your env (unless it's incompatible with the other build requirements, in which case the resolver should get you a compatible version of torch). |
kszlim
commented
Jun 18, 2024
| dependencies = [ | ||
| "torch", | ||
| "einops", | ||
| "numpy", |
There was a problem hiding this comment.
tests output a warning if numpy isn't installed.
|
@tridao sorry, I realize this is a drive by pr, but is it something you'll consider or should I close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if i pip install this package or
uv pip installit, it will work, should also close #24 i believe also should close #2.Tests all passed too.