Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make properly pip installable without needing build isolation (uv pip install now works too) #402

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

kszlim
Copy link
Contributor

@kszlim kszlim commented Jun 18, 2024

Now you can just pip install mamba_ssm and it will work, previously it would throw unless you had packaging and torch already installed. It would also always fail if you had build isolation on (which will be on by default in the future within pip).

As a side effect, now uv can uv pip install mamba_ssm properly now.

Take note that installing causal-conv1d via the optional extra will still fail with build isolation due to that package needing similar changes to this one.

@kszlim
Copy link
Contributor Author

kszlim commented Jun 18, 2024

I tested this by creating an empty workspace/venv where i pip installed mamba_ssm into with uv and pip with build isolation on.

I also verified that I could run the benchmark.

Please give this a spin and see if it works for you.

@kszlim
Copy link
Contributor Author

kszlim commented Jun 18, 2024

If Dao-AILab/causal-conv1d#26 is merged, then:

Take note that installing causal-conv1d via the optional extra will still fail with build isolation due to that package needing similar changes to this one.

Should no longer be true.

@kszlim
Copy link
Contributor Author

kszlim commented Jul 22, 2024

@albertfgu @tridao any chance this can be accepted (i'll update it if so), otherwise this can be closed.

@riZZZhik
Copy link

riZZZhik commented Aug 5, 2024

@albertfgu @tridao Hi,

Can you approve this pr?
It actually fixes installation issues with this library

btw @kszlim thanks, good work!

@kdre
Copy link

kdre commented Aug 6, 2024

Please approve this pr. It also fixed my installation issue.

@tridao tridao merged commit 323db26 into state-spaces:main Aug 6, 2024
@amrit110
Copy link

Hi @tridao when is a new release to pypi expected with this fix? The installation of the latest available package fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants