Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remoteconfig][beta] add doc #1236

Merged
merged 4 commits into from
Jun 18, 2024
Merged

[remoteconfig][beta] add doc #1236

merged 4 commits into from
Jun 18, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Add doc about RemoteConfig feature

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@celenechang celenechang added documentation Improvements or additions to documentation qa/skip-qa labels Jun 14, 2024
@celenechang celenechang requested review from a team as code owners June 14, 2024 16:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (288d981) to head (207a01d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1236   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         177      177           
  Lines       22371    22371           
=======================================
  Hits        13273    13273           
  Misses       8286     8286           
  Partials      812      812           
Flag Coverage Δ
unittests 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288d981...207a01d. Read the comment docs.

Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small suggestions for you to consider from Docs. 😄

docs/remote_config.md Outdated Show resolved Hide resolved
docs/remote_config.md Outdated Show resolved Hide resolved
docs/remote_config.md Outdated Show resolved Hide resolved
@celenechang
Copy link
Contributor Author

thanks @brett0000FF !


Remote Configuration in the Datadog Operator allows you to enable features in a Kubernetes cluster from Datadog.

You can create a policy on the Fleet Automation page to enable a feature for an eligible scope. The Datadog Operator then updates the Agents with the necessary configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reference some public doc here? It wouldn't be obvious what policy or scope means for people new to RC.
E.g. one of these or both
https://docs.datadoghq.com/agent/remote_config/
https://www.datadoghq.com/blog/remote-configuration-for-datadog/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to intentionally during this beta

@celenechang celenechang merged commit 800fdbe into main Jun 18, 2024
19 checks passed
@celenechang celenechang deleted the celene/rc_doc_beta branch June 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants