Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XValidation rule as requires K8S >= 1.25 (#1339) #1347

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Aug 9, 2024

What does this PR do?

cherry-pick #1339

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@levan-m levan-m requested a review from a team as a code owner August 9, 2024 16:52
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling, dependencies

@levan-m levan-m added bug Something isn't working qa/skip-qa labels Aug 9, 2024
@levan-m levan-m added this to the v1.8.0 milestone Aug 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.24%. Comparing base (f452dac) to head (8f4fa4c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.8    #1347   +/-   ##
=======================================
  Coverage   55.24%   55.24%           
=======================================
  Files         247      247           
  Lines       28403    28403           
=======================================
  Hits        15690    15690           
  Misses      11829    11829           
  Partials      884      884           
Flag Coverage Δ
unittests 55.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/datadoghq/v1alpha1/datadogpodautoscaler_types.go 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f452dac...8f4fa4c. Read the comment docs.

@levan-m levan-m merged commit 1640ba7 into v1.8 Aug 9, 2024
18 of 20 checks passed
@levan-m levan-m deleted the levan-m/cherry-pick-1339 branch August 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants