Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XValidation rule as requires K8S >= 1.25 (#1339) #1347

Merged
merged 1 commit into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apis/datadoghq/v1alpha1/datadogpodautoscaler_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ const (
// DatadogPodAutoscalerSpec defines the desired state of DatadogPodAutoscaler
type DatadogPodAutoscalerSpec struct {
// TargetRef is the reference to the resource to scale.
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Modifying the targetRef is not allowed. Please delete and re-create the DatadogPodAutoscaler object."
TargetRef autoscalingv2.CrossVersionObjectReference `json:"targetRef"`

// Owner defines the source of truth for this object (local or remote)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,6 @@ spec:
- kind
- name
type: object
x-kubernetes-validations:
- message: Modifying the targetRef is not allowed. Please delete and re-create the DatadogPodAutoscaler object.
rule: self == oldSelf
targets:
description: |-
Targets are objectives to reach and maintain for the target resource.
Expand Down
Loading