feat: meta_struct support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
eliottness/delete-meta-struct
branch
from
567af52
to
d5035d1
Compare
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
eliottness/delete-meta-struct
branch
from
d5035d1
to
53ef913
Compare
|
It seems that the CI is broken with the following error: |
|
ah yes ignore that error, there's some weird dependency issue that broke in the changelog job! |
Kyle-Verhoog
requested changes
Aug 14, 2024
RomainMuller
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM (modulo the same concern that @Kyle-Verhoog expressed in his review)
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
eliottness
force-pushed
the
eliottness/delete-meta-struct
branch
from
9d1aceb
to
6ed45f8
Compare
![datadog-staging-us1-crawler-test[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Kyle-Verhoog
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a specific field supported since agent version v7.31 called
meta_structwhich encapsulate another layer of msgpack values inside the main msgpack chunk.Motivation
Appsec has been using this field to store stacktraces for multiple quarters already. We need to be able to test this feature
Notes to reviewer
Not overly happy about this implementation but there is not obvious way to do a first round of type checking, modify the span object, and then do a second round of type-checking. So I've simply put everything in the
verify_spanfunction.