Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(integration-tests): use container test agent #248

Closed

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Aug 27, 2024

What

This PR replaces all the code installing and managing the ddapm-test-agent process in favor of a testcontainer.

Why

Benefits:

  • Being able to run the testsuite as root more easily because python packages as root are broken
  • The latest docker image is built with the last commit on main which contains feat: meta_struct support dd-apm-test-agent#184 and remove the need for this kind of trick like here b74fc7b
  • No need to install python in the workflows

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness force-pushed the eliott.bouhana/switch-test-agent-to-container branch from b30935f to 6532dd8 Compare August 27, 2024 13:58
@eliottness
Copy link
Contributor Author

Docker is not available on windows and macos runners

@eliottness eliottness closed this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.31%. Comparing base (981f2c7) to head (6532dd8).

Files Patch % Lines
_integration-tests/utils/agent/agent.go 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   62.57%   67.31%   +4.73%     
==========================================
  Files         101       99       -2     
  Lines        5259     4347     -912     
==========================================
- Hits         3291     2926     -365     
+ Misses       1627     1079     -548     
- Partials      341      342       +1     
Components Coverage Δ
Instruments 34.56% <ø> (ø)
Go Driver 67.24% <ø> (+4.32%) ⬆️
Toolexec Driver 69.24% <ø> (+3.40%) ⬆️
Aspects 78.05% <ø> (+8.08%) ⬆️
Injector 77.87% <ø> (+6.22%) ⬆️
Files Coverage Δ
_integration-tests/utils/agent/agent.go 0.00% <0.00%> (ø)

... and 80 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant