Add new tls_only choice to the bearer_token parameter that sends the bearer token only to secure HTTPS endpoints
#10706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
L3n41c
force-pushed
the
lenaic/auto_bearer
branch
from
3dd43c1
to
3c097b4
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
vboulineau
previously approved these changes
Nov 23, 2021
4 tasks
L3n41c
force-pushed
the
lenaic/auto_bearer
branch
from
3c097b4
to
5eaf4a1
Compare
4 tasks
vickenty
reviewed
Nov 24, 2021
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
L3n41c
force-pushed
the
lenaic/auto_bearer
branch
4 times, most recently
from
0b43b4c
to
e442c2b
Compare
4 tasks
to send the bearer token only to secure https endpoints and not to clear text http endpoints.
L3n41c
force-pushed
the
lenaic/auto_bearer
branch
from
e442c2b
to
3444d84
Compare
|
/azp help |
Supported commands
See additional documentation. |
|
/azp list |
|
/azp run PR All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run PR All |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ofek
approved these changes
Dec 2, 2021
ofek
changed the title
bearer_token parameter to send the bearer token only to secure https endpoints by defaulttls_only choice to the bearer_token parameter that sends the bearer token only to secure HTTPS endpoints
vickenty
approved these changes
Dec 6, 2021
ahmed-mez
approved these changes
Dec 28, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
to send the bearer token only to secure https endpoints and not to clear text http endpoints. 82a3e20
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
to send the bearer token only to secure https endpoints and not to clear text http endpoints.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the meaning of the default value of the
bearer_tokenparameter of the OpenMetrics based checks.The default behaviour if not set is now to send the bearer token to secure
httpsendpoints and not to clear texthttpendpoints.Motivation
This is useful for all the checks that are leveraging the
possible_prometheus_urlsto try to autodetect what is the usable endpoint url based on a list of commonly used ones.This is the case for the Kubernetes control plane components checks.
Additional Notes
kube_controller_manager: Update the default value of thebearer_tokenparameter to send the bearer token only to secure https endpoints by default #10708kube_scheduler: Update the default value of thebearer_tokenparameter to send the bearer token only to secure https endpoints by default #10709kube_apiserver_metrics: Update the default value of thebearer_tokenparameter to send the bearer token only to secure https endpoints by default #10772Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached