-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the default value of the bearer_token
parameter to send the bearer token only to secure https endpoints by default
#10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The |
L3n41c
force-pushed
the
lenaic/auto_bearer_kube_scheduler
branch
from
November 23, 2021 13:02
160a50e
to
b52a42d
Compare
The |
to send the bearer token only to secure https endpoints and not to clear text http endpoints.
L3n41c
force-pushed
the
lenaic/auto_bearer_kube_scheduler
branch
from
December 1, 2021 13:16
b52a42d
to
c1e77d0
Compare
ofek
requested changes
Dec 2, 2021
The |
L3n41c
force-pushed
the
lenaic/auto_bearer_kube_scheduler
branch
from
December 27, 2021 12:38
bd65227
to
02b5660
Compare
/azp run PR Changes |
Commenter does not have sufficient privileges for PR 10709 in repo DataDog/integrations-core |
/azp run PR Changes |
Azure Pipelines failed to run 1 pipeline(s). |
/azp run PR Changes |
1 similar comment
/azp run PR Changes |
Azure Pipelines successfully started running 1 pipeline(s). |
ahmed-mez
approved these changes
Dec 28, 2021
ofek
approved these changes
Dec 28, 2021
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
…bearer token only to secure https endpoints by default (#10709) to send the bearer token only to secure https endpoints and not to clear text http endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the default behaviour of the auto-configuration of the
kube_scheduler
check.By default, when trying all the possible endpoints, the bearer token will be sent only to secure https endpoints.
Motivation
Make the check work out of the box without leaking the token on an insecure connection on both clusters where only the insecure
http
endpoint is available and on clusters where only the securehttps
endpoint is available.Additional Notes
Leverages #10706
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached