Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for when stream metrics are disabled on nginx v7 #10804

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds another test to nginx for when stream metrics are disabled on nginx v7

Motivation

More testing related to: #10750

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #10804 (cbf44a5) into master (76a249c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Flag Coverage Δ
nginx 96.37% <100.00%> (+0.78%) ⬆️
postgres 91.49% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review December 7, 2021 18:59
@sarah-witt sarah-witt requested a review from a team as a code owner December 7, 2021 18:59
@sarah-witt sarah-witt merged commit 6a456b3 into master Dec 7, 2021
@sarah-witt sarah-witt deleted the sarah/nginx-7-test branch December 7, 2021 20:35
cswatt pushed a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants