Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be specific about the exposition formats supported #14370

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Apr 13, 2023

What does this PR do?

Clarifies what formats are supported by the OpenMetrics check and how to configure which format is used.

Motivation

AI-2416.

The docs don't provide any clarity as to what the actual format that we support by default in the OpenMetrics check is and the name of the check (OpenMetrics, when we already have a check called Prometheus) doesn't help, considering we're actually assuming Prometheus format by default and not OpenMetrics. It's also not obvious how to enable OpenMetrics spec support (I'll be updating the config template to add some documentation in there as well).

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@alopezz alopezz force-pushed the alopez/openmetrics/docs-exposition-formats branch from 3b033e4 to 0b828e4 Compare April 13, 2023 14:37
@alopezz alopezz added the qa/skip-qa Automatically skip this PR for the next QA label Apr 13, 2023
hestonhoffman
hestonhoffman previously approved these changes Apr 13, 2023
As those are no longer needed after #14445.
@alopezz alopezz merged commit 0e74332 into master Apr 26, 2023
@alopezz alopezz deleted the alopez/openmetrics/docs-exposition-formats branch April 26, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants