Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description of use_latest_spec in OpenMetrics-based checks #14371

Closed
wants to merge 2 commits into from
Closed

Improve description of use_latest_spec in OpenMetrics-based checks #14371

wants to merge 2 commits into from

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Apr 13, 2023 •
edited by jira bot
Loading

What does this PR do?

Adds an explanation of what use_latest_spec actually does.

Motivation

AI-2416. See also #14370.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@alopezz alopezz added changelog/Fixed qa/skip-qa Automatically skip this PR for the next QA labels Apr 13, 2023
@alopezz alopezz requested review from a team as code owners April 13, 2023 15:23
@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #14371 (1252566) into master (d4f33c2) will increase coverage by 0.14%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.71% <ø> (+2.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alopezz
Copy link
Contributor Author

alopezz commented Apr 25, 2023

Superseded by #14445 and #14446.

@alopezz alopezz closed this Apr 25, 2023
@dd-devflow dd-devflow bot deleted the alopez/openmetrics/use_latest_spec_doc branch February 7, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@hestonhoffman hestonhoffman hestonhoffman approved these changes

Assignees
No one assigned
Labels
dev_package dev/tooling do-not-merge/HOLD integration/aerospike integration/amazon_msk integration/arangodb integration/argocd integration/avi_vantage integration/boundary integration/calico integration/cert_manager integration/cilium integration/cockroachdb integration/coredns integration/envoy integration/gitlab integration/haproxy integration/impala integration/istio integration/kong integration/linkerd integration/openmetrics integration/pulsar integration/rabbitmq integration/teamcity integration/temporal integration/vault qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alopezz @FlorentClarret @hestonhoffman