Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssl variable naming for IBM MQ #3312

Merged
merged 2 commits into from
Mar 18, 2019
Merged

fix ssl variable naming for IBM MQ #3312

merged 2 commits into from
Mar 18, 2019

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Mar 18, 2019

What does this PR do?

There was a bug in the code because I misnamed the variable. This should fix it.

Motivation

Customer bug report

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@gmmeyer gmmeyer requested a review from a team as a code owner March 18, 2019 10:54
@codecov
Copy link

codecov bot commented Mar 18, 2019 •
edited
Loading

Codecov Report

Merging #3312 into master will decrease coverage by 5.23%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3312      +/-   ##
==========================================
- Coverage   85.16%   79.93%   -5.24%     
==========================================
  Files         685       10     -675     
  Lines       36106      309   -35797     
  Branches     4356       27    -4329     
==========================================
- Hits        30751      247   -30504     
+ Misses       4144       56    -4088     
+ Partials     1211        6    -1205

coignetp
coignetp previously approved these changes Mar 18, 2019
View reviewed changes
nmuesch
nmuesch reviewed Mar 18, 2019
View reviewed changes
ibm_mq/datadog_checks/ibm_mq/connection.py
@@ -58,7 +58,7 @@ def get_ssl_connection(config):
cd.SSLCipherSpec = config.ssl_cipher_spec

sco = pymqi.SCO()
sco.KeyRepository = config.key_repo_location
sco.KeyRepository = config.ssl_key_repository_location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

integrations-core/ibm_mq/datadog_checks/ibm_mq/config.py

Line 51 in 7169c69

self.key_repository_location = instance.get(
key_repository_location, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

nmuesch
nmuesch approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚀 once CI is green 🙇

@gmmeyer gmmeyer changed the title fix variable naming for IBM MQ fix ssl variable naming for IBM MQ Mar 18, 2019
@gmmeyer gmmeyer merged commit 07c54bc into master Mar 18, 2019
@gmmeyer gmmeyer deleted the greg/ssl branch March 18, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch approved these changes

@coignetp coignetp coignetp left review comments

Assignees
No one assigned
Labels
integration/ibm_mq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmmeyer @nmuesch @coignetp