Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssl variable naming for IBM MQ #3312

Merged
merged 2 commits into from
Mar 18, 2019
Merged

fix ssl variable naming for IBM MQ #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7169c69
fix variable naming for IBM MQ
gmmeyer Mar 18, 2019
912ef06
fix
gmmeyer Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ibm_mq/datadog_checks/ibm_mq/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def __init__(self, instance):
self.ssl = is_affirmative(instance.get('ssl_auth', False))
self.ssl_cipher_spec = instance.get('ssl_cipher_spec', 'TLS_RSA_WITH_AES_256_CBC_SHA')

self.key_repository_location = instance.get(
self.ssl_key_repository_location = instance.get(
'ssl_key_repository_location',
'/var/mqm/ssl-db/client/KeyringClient'
)
Expand Down
2 changes: 1 addition & 1 deletion ibm_mq/datadog_checks/ibm_mq/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def get_ssl_connection(config):
cd.SSLCipherSpec = config.ssl_cipher_spec

sco = pymqi.SCO()
sco.KeyRepository = config.key_repo_location
sco.KeyRepository = config.ssl_key_repository_location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

integrations-core/ibm_mq/datadog_checks/ibm_mq/config.py

Line 51 in 7169c69

self.key_repository_location = instance.get(
key_repository_location, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!


queue_manager = pymqi.QueueManager(None)
queue_manager.connect_with_options(config.queue_manager, cd, sco)
Expand Down