Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-discovery for latest versions on Kubernetes #9577

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Jun 22, 2021

What does this PR do?

Leverages the possible_prometheus_urls parameter introduced by #9573 in the auto-discovery configuration file.

Motivation

Make the agent able to automatically monitor the Kube API server on most recent versions of Kubernetes without requiring too much user setup.
The goad is to simplify the Kubernetes control plane monitoring setup described in DataDog/documentation#10828.

Additional Notes

Depending on the Kubernetes distribution, the API server can listen on two different default ports: 8443 and 6443.
We need to try both in the auto-discovery configuration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the documentation label Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #9577 (acb4edb) into master (e97eb15) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
kube_apiserver_metrics 97.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@L3n41c L3n41c merged commit 0548518 into master Jul 1, 2021
@L3n41c L3n41c deleted the lenaic/kube_apiserver_metrics branch July 1, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants