Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s control plane docs #10828

Merged
merged 7 commits into from
Jun 28, 2021
Merged

K8s control plane docs #10828

merged 7 commits into from
Jun 28, 2021

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Document how to configure Control Plane integrations on k8s + kubeadm

Preview

https://docs-staging.datadoghq.com/ahmed/k8s-control-plane-monitoring/agent/kubernetes
https://docs-staging.datadoghq.com/ahmed/k8s-control-plane-monitoring/agent/kubernetes/control_plane

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@ahmed-mez ahmed-mez requested a review from a team as a code owner June 14, 2021 08:35
@github-actions github-actions bot added the agent Content changed in the Agent folder label Jun 14, 2021
@ahmed-mez ahmed-mez force-pushed the ahmed/k8s-control-plane-monitoring branch from 1bbd48a to 0f634e1 Compare June 14, 2021 09:56
@clamoriniere
Copy link
Contributor

Hi @ahmed-mez
On which Kubernetes version did you tested? could you add the compatible version?

cswatt
cswatt requested changes Jun 14, 2021
View reviewed changes
content/en/agent/kubernetes/_index.md Outdated Show resolved Hide resolved
content/en/agent/kubernetes/control_plane.md Outdated Show resolved Hide resolved
content/en/agent/kubernetes/control_plane.md Outdated Show resolved Hide resolved
content/en/agent/kubernetes/control_plane.md Outdated Show resolved Hide resolved
@ahmed-mez
Copy link
Contributor Author

Thank you @Simwar @celenechang and @cswatt for the review!
@clamoriniere I tested it on 1.18, 1.19, 1.20, and 1.21. I just added a note that these configs are tested on k8s 1.18+

@ahmed-mez ahmed-mez force-pushed the ahmed/k8s-control-plane-monitoring branch from 6632c57 to 76cbce0 Compare June 21, 2021 12:00
This was referenced Jun 22, 2021
Merged
Merged
Merged
Merged
@apigirl apigirl force-pushed the ahmed/k8s-control-plane-monitoring branch from 76cbce0 to fbd47c0 Compare June 24, 2021 18:33
@ahmed-mez ahmed-mez requested review from a team June 24, 2021 18:33
ahmed-mez and others added 2 commits June 25, 2021 15:43
@ahmed-mez @celenechang
Update content/en/agent/kubernetes/control_plane.md
b9d5608 
Co-authored-by: Celene <celene@datadoghq.com>
@ahmed-mez @celenechang
Update content/en/agent/kubernetes/control_plane.md
b2fe49f 
Co-authored-by: Celene <celene@datadoghq.com>
@ahmed-mez
Copy link
Contributor Author

@cswatt @apigirl could we merge the PR?

@cswatt cswatt merged commit 2af8d46 into master Jun 28, 2021
@cswatt cswatt deleted the ahmed/k8s-control-plane-monitoring branch June 28, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simwar Simwar Simwar left review comments

@cswatt cswatt cswatt approved these changes

@celenechang celenechang celenechang approved these changes

Assignees
No one assigned
Labels
agent Content changed in the Agent folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmed-mez @clamoriniere @Simwar @cswatt @celenechang