Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-discovery for latest versions on Kubernetes #9578

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Jun 22, 2021

What does this PR do?

Leverages the prometheus_possible_urls parameter introduced by #9573 in the auto-discovery configuration file.

Motivation

The goad is to simplify the Kubernetes control plane monitoring setup described in DataDog/documentation#10828.

Additional Notes

On older versions of Kubernetes, the etcd metrics were available at http://%%host%%:2379/metrics where %%host%% is the node IP.
On most recent version of Kubernetes, the etcd port is exposed only on secure https endpoint and requires ssl client certificate for authentication.

Whereas a client can decide to ignore a server certificate validation, a client has (thankfully) no way to ask the server to ignore client certificate validation.

That’s why the client ssl certificates needed to talk to etcd will need to be mounted from the host as described in DataDog/documentation#10828.

For etcd, there’s unfortunately no way to make integration work out-of-the-box without any user configuration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the documentation label Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #9578 (225faa1) into master (e97eb15) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
etcd 93.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

cswatt
cswatt previously approved these changes Jun 22, 2021
@L3n41c L3n41c merged commit 51f022f into master Sep 29, 2021
@L3n41c L3n41c deleted the lenaic/etcd branch September 29, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants