Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-discovery for latest versions on Kubernetes #9578

Merged
merged 3 commits into from
Sep 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion etcd/assets/configuration/spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,32 @@ files:
options: []
- template: instances
options:
- name: possible_prometheus_urls
required: true
description: |
The URLs to try to get your application metrics that are exposed by Prometheus.
The check will try each URLs in the list and will use the first working one.
One of possible_prometheus_urls or prometheus_url parameter is required.
value:
type: array
items:
type: string
example:
- https://%%host%%:2379/metrics
- http://%%host%%:2379/metrics
- name: prometheus_url
description: |
Prometheus endpoint of your etcd instance.
One of possible_prometheus_urls or prometheus_url parameter is required.

Note: To monitor ETCD versions pre-3.x.x, set `use_preview` to `false` and use the `url` configuration option.
required: true
required: false
value:
example: http://%%host%%:2379/metrics
type: string
- name: ssl_verify
required: true
description: Used to verify self signed certificates.
value:
type: boolean
example: false
19 changes: 17 additions & 2 deletions etcd/datadog_checks/etcd/data/auto_conf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,24 @@ init_config:
#
instances:

## @param prometheus_url - string - required
## @param possible_prometheus_urls - list of strings - required
## The URLs to try to get your application metrics that are exposed by Prometheus.
## The check will try each URLs in the list and will use the first working one.
## One of possible_prometheus_urls or prometheus_url parameter is required.
#
- possible_prometheus_urls:
- https://%%host%%:2379/metrics
- http://%%host%%:2379/metrics

## @param prometheus_url - string - optional - default: http://%%host%%:2379/metrics
## Prometheus endpoint of your etcd instance.
## One of possible_prometheus_urls or prometheus_url parameter is required.
##
## Note: To monitor ETCD versions pre-3.x.x, set `use_preview` to `false` and use the `url` configuration option.
#
- prometheus_url: http://%%host%%:2379/metrics
# prometheus_url: http://%%host%%:2379/metrics

## @param ssl_verify - boolean - required
## Used to verify self signed certificates.
#
ssl_verify: false