Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feature: ONNX support for evaluation #233

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

YuriCat
Copy link
Contributor

@YuriCat YuriCat commented Jan 11, 2022

ONNX models are very useful for both competitions and business projects.

@ikki407
Copy link
Member

ikki407 commented Jan 13, 2022

Should we add an PyTorch->ONNX model conversion script at utils.py?

python main.py --torch2onnx TORCH_MODEL [OUTPUT_MODEL]

@YuriCat
Copy link
Contributor Author

YuriCat commented Jan 22, 2022

I prefer script/make_onnx_model.py, but this might be because I have been using that.

@ikki407
Copy link
Member

ikki407 commented Jan 26, 2022

LGTM!

@ikki407 ikki407 merged commit 3b29cdf into DeNA:develop Jan 26, 2022
@YuriCat YuriCat deleted the feature/onnx_model branch February 11, 2022 17:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants