feature: add make_onnx_model.py #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikki407
reviewed
Jan 26, 2022
scripts/make_onnx_model.py
Outdated
Comment on lines
23
to
28
| model.load_state_dict(torch.load(model_path), strict=False) | ||
| model.eval() | ||
| model = ModelWrapper(model) | ||
|
|
||
| model.load_state_dict(torch.load(model_path), strict=False) | ||
| model.eval() |
There was a problem hiding this comment.
stopped importing and using ModelWrapper since it is used only for init_hidden()
|
Since turn() is not always defined, turns()[0] is better. |
|
At initial state, a chance node perhaps exist depending on the implementation of the game (e.g. coin toss). |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#233 enables us to use ONNX model created by this script.