Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency updates #40

Merged
merged 14 commits into from
Feb 9, 2022

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Feb 7, 2022

Add a special workflow for updating requirements.txt.
Dependabot does not update requirements.txt anymore then, but only the development requirements.
In order to make this work, the requirements_dev.txt (development requirements) have been moved to a separate folder (/.dev).
All references to requirements_dev.txt have been updated accordingly (only used in CI/CD workflows and the development target for Dockerfile).

The new workflow checks out the ci/dependabot-updates branch, installs a set list of direct requirements (without versions), being eager in updating versions when installing, and then runs pip freeze to check against the current requirements.txt file.
If there are any changes, a PR against ci/dependabot-updates is created - similarly to what dependabot would otherwise do.
The workflow is scheduled to run every Monday morning - similarly to when dependabot runs.

Closes #38

The new workflow will be scheduled to run every Monday.
Dependabot now only checks the Python dependencies for the development
requirements (`requirements_dev.txt`), which needed to be moved to a
separate folder for this to work (`/.dev`).
Add `hypercorn` as a direct dependency
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #40 (741826c) into master (2f1c3dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files           8        8           
  Lines         295      295           
=======================================
  Hits          205      205           
  Misses         90       90           
Flag Coverage Δ
pytest 69.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1c3dd...741826c. Read the comment docs.

Copy link
Contributor

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a minor typo in a comment. Otherwise a very nice PR

.github/workflows/ci_update_requirements.yml Outdated Show resolved Hide resolved
CasperWA and others added 2 commits February 9, 2022 09:27
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
@CasperWA CasperWA enabled auto-merge (squash) February 9, 2022 08:28
@CasperWA CasperWA merged commit c9bcef1 into master Feb 9, 2022
@CasperWA CasperWA deleted the cwa/close-38-simplify-dependency-updates branch February 9, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing dependabot with a custom workflow
3 participants