Use the get() method throughout for strategies
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the parse strategy specifically, which used to have a `parse()` method instead of a `get()`, which was fixed in oteapi-core v0.0.5.
CasperWA
added
bug
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 69.49% 69.49%
=======================================
Files 8 8
Lines 295 295
=======================================
Hits 205 205
Misses 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I will force this bug fix through as the change is not actually reviewable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the parse strategy specifically, which used to have a
parse()method instead of aget(), which was fixed in oteapi-corev0.0.5.
Fixes #41