Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up using custom JSON decoders/encoders #96

Closed
wants to merge 1 commit into from

Conversation

CasperWA
Copy link
Contributor

Closes #79

This will retrieve JSON encoders from POSTed data within the configurations, and JSON decoders from URL query parameters.

This is the initial work for the intended implementation of custom JSON
decoders/encoders and will act as the basis for a discussion before
implementing it throughout the code.
@CasperWA
Copy link
Contributor Author

@jesper-friis I have implemented the way I think custom JSON encoders and decoders should be retrieved for the /filter router. I hope we can use this as a grounds of discussion concerning whether this is the way to do things or not - after we agree it can be reproduced in the rest of the code base.

@codecov-commenter
Copy link

Codecov Report

Merging #96 (ba314f0) into master (1ae3b76) will decrease coverage by 1.17%.
The diff coverage is 55.17%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   69.87%   68.69%   -1.18%     
==========================================
  Files          17       17              
  Lines         468      492      +24     
==========================================
+ Hits          327      338      +11     
- Misses        141      154      +13     
Flag Coverage Δ
pytest 68.69% <55.17%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/routers/datafilter.py 68.57% <55.17%> (-11.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae3b76...ba314f0. Read the comment docs.

@CasperWA
Copy link
Contributor Author

This, I think, can now be closed. The idea of custom JSON decoders/encoders is old and should be reconsidered. The issue of whether it should be included in the first place should first be discussed before implementation suggestions pop up.

@CasperWA CasperWA closed this Sep 20, 2023
@CasperWA CasperWA deleted the cwa/close-79-custom-JSON-encoders branch September 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom JSON encoders for serialising of the session
2 participants