-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated data image #69
base: main
Are you sure you want to change the base?
Conversation
image_definitions/data/Dockerfile
Outdated
RUN pip install databricks-cli pre-commit tomli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally add "azure-cli" here rather than separate line otherwise we create unnecessary docker layers, happy to approve now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure cli is already in the base image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jack, I can see it in base image but I think its getting removed from data image ,please refer this
RUN apk del py-pip \
&& apk del python3-dev py3-pip
&& rm -rf ~/.cache/pip \
&& apk del python3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@russellseymour shouldn't az cli be available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, juust catching up with PRs
Yes I was just looking at this.
If we are upgrading Python herte then I think we should be consistent and upgrage Python in the base image.
I do not want to have to install az
twice.
Hey @russellseymour, has this PR become part of our new images? |
📲 What
Added jq and azure-cli in data image
🤔 Why
Why have you implemented it?
Required for Data platform