Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated data image #69

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

updated data image #69

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5dc340
updated data image
satenderrathee Sep 25, 2023
6168289
updated
satenderrathee Sep 27, 2023
98d6df9
updated
satenderrathee Sep 27, 2023
cabc507
updated
satenderrathee Sep 27, 2023
cdb55c4
updated
satenderrathee Sep 27, 2023
deb65b7
Update Dockerfile
satenderrathee Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions image_definitions/data/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ RUN echo "https://dl-cdn.alpinelinux.org/alpine/v3.17/community" >> /etc/apk/rep
RUN apk update

# Add latest version of python and poetry
RUN apk add --update python3 py3-pip gcc musl-dev linux-headers python3-dev
RUN apk add --update python3 py3-pip gcc musl-dev linux-headers python3-dev jq
RUN pip install pytest pylint pylint-exit pytest-azurepipelines pytest-cov poetry

# Install the databricks CLI, precommit and tomli
RUN pip install databricks-cli pre-commit tomli
RUN pip install databricks-cli pre-commit tomli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally add "azure-cli" here rather than separate line otherwise we create unnecessary docker layers, happy to approve now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure cli is already in the base image?

Copy link
Contributor Author

@satenderrathee satenderrathee Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jack, I can see it in base image but I think its getting removed from data image ,please refer this
RUN apk del py-pip \
&& apk del python3-dev py3-pip
&& rm -rf ~/.cache/pip \
&& apk del python3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellseymour shouldn't az cli be available?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, juust catching up with PRs

Yes I was just looking at this.

If we are upgrading Python herte then I think we should be consistent and upgrage Python in the base image.
I do not want to have to install az twice.


# Install Azure CLI in the Data image
RUN pip install azure-cli
ElvenSpellmaker marked this conversation as resolved.
Show resolved Hide resolved