-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add soil surface layer, bare soil surface layer; edit soil biocrust #751
Conversation
Changed the axiom so that soil biocrust is a part of a soil surface layer.
Hmm, contains / contained in doesn't include parthood, and plant matter is often considered part of soils. Also, just because soil has plant matter in it doesn't mean it's not "bare" in the sense of "uncovered". We need a class for "bare soil" itself, where we can sort out these semantics. It would be better to put the axioms about why it's bare in the material rather than the layer. Do you have a good definition for this class? Here are some usages... Here are some edits I think will help:
|
The definition in the dbxref (link) is a bit too terse. I'm not sure this means that the soil has no plant matter in it, I think it's more above being covered if I think in terms of the NLCD classes (see #458) Thus I would change the def of the layer to:
|
I think you're right. I took a closer look at the dataset we want to annotate and see that it's funded by NASA's LCLUC program. So, a def that is about land coverage does make sense here. |
Maybe |
I think we can make a new issue for that. There are terms like @stevenchong do you want to add the envoNceas subset tag to any of the other terms created in this PR? Once you're done, we can merge. |
Relevant to #750.
For
bare soil surface layer
, please check the axiom describing the lack of plant matter -- was having an internal debate about usingcontains
vs.has part
.