This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fixing auto reconnect to not reconnect when the page is refreshed. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Cotton <matt@tensorworks.com.au>
…mingInfrastructure into fix_autoconnect
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Described in #281
When the option "OfferToReceive" is set, if the user refreshes the page during a stream the frontend will immediately try to reconnect to the SS before immediately disconnecting again.
Solution
The on close event now checks the code of the event to check whether the close event was caused by the local machine or not.