Set up Playwright screenshot testing #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
And added testing for `/blog/272`.
Also, slightly refactored `src\routes\(site)\about\officer-profile.svelte` to remove unused code.
And removed threshold of 0.1 since the default of 0.2 should be better. If not, we should bump it up to 0.3.
Added waitFor: 'network-idle' in an attempt to wait for the JS to load. Also removed tests for blog page since there is currently no way of running the Playwright tests with DEBUG_MODE_ENABLED sadly.
Replaced threshold with a starting `maxDiffPixelRatio: 0.1` and a lax threshold of `threshold: 1`.
|
HUGE 🧠 |
This kinda took way too long to test :/ BUT screenshot tests are cool and convenient.
- Mobile matches Samsung Galaxy S7 Edge - Tablet matches Samsung Galaxy Tab 10
EthanThatOneKid
force-pushed
the
fix/557
branch
from
652ec34
to
a3b9007
Compare
EthanThatOneKid
force-pushed
the
fix/557
branch
from
32e86e5
to
29a0712
Compare
EthanThatOneKid
force-pushed
the
fix/557
branch
from
29a0712
to
f7a74fd
Compare
|
This PR is intended to introduce a new feature as a trial run. If the new feature (Playwright screenshot testing) works out to be more of a hinderance than a convenience, then I will remove this feature sometime near the end of the Fall 2022 semester. |
jaasonw
approved these changes
Oct 14, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we can do now
npm thas now been upgraded to include parallelized Playwright tests and screenshot diff testing. To specifically test the Playwright tests and not the Vitest tests, you may runnpm run test:browser. Make some changes on screenshot-tested pages and give it a try!Change log
/tests/test.tstests into each page of the/src/routes/directory.projectsFromMatrixhelper to generate a matrix of screenshots to be taken per page.vitest.config.tsto exclude Playwright tests from the Vitest testing./src/routes/screenshots/./1stpage./aboutpage./blogpage./blog/:idpage./eventspage./nodebudspage./privacypage./quizpage./teamspage.Resolves #557.