Removed screenshot testing from complex pages #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some acmcsuf.com pages give the Playwright testing some trouble, being capable of generating nondeterministic screenshots. This is a problem and should be stripped out of the main branch for now so that the nondeterministic screenshot tests may be rewritten on a case-by-case basis.
Removed screenshot tests for `/event` page TODO: Run Playwright tests on another computer to make sure the tests are behaving as expected.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot testing was recently added in #612. It includes automatic screenshot testing for all
acmcsuf.compages despite not every page rendering deterministically. Screenshot testing should only be applied to pages that do not move much (which is expected behavior on a majority of our pages). For this reason, screenshot tests are prone to failure for the/events,/blog, and/1stpages.Note: To support screenshot tests on pages with nondeterministic full-page screenshots, screenshots must instead be taken of individual page elements which are deterministic.