check for process.env.VERCEL_ANALYTICS_ID #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
What issue is this PR resolving? |
|
the issue where it shows a bunch of red text in my console when i npm run dev |
|
The analytics ID is currently injected into the build at build time in Line 9 in 6f43b29 SvelteKit generates types for the available environment variables at build time. I think it might be possible to extend the functionality described here: https://kit.svelte.dev/docs/modules#$env-dynamic-public. |
EthanThatOneKid
added a commit
that referenced
this pull request
Oct 26, 2022
- Refactored analytics library: factored out `send.ts` into `vitals.ts`. Addresses <#630 (comment)>. Thanks @jaasonw for kicking off this PR :)
- Refactored analytics library: factored out `send.ts` into `vitals.ts`. - Added env variables to pass `website_check.yaml` workflow. Addresses <#630 (comment)>. Thanks @jaasonw for kicking off this PR :)
EthanThatOneKid
force-pushed
the
check_anal_id
branch
from
f952e09
to
ee8622e
Compare
- Refactored analytics library: factored out `send.ts` into `vitals.ts`. - Added env variables to pass `website_check.yaml` workflow. Addresses <#630 (comment)>. Thanks @jaasonw for kicking off this PR :)
EthanThatOneKid
force-pushed
the
check_anal_id
branch
from
7b9ee10
to
8327b18
Compare
EthanThatOneKid
force-pushed
the
check_anal_id
branch
from
8327b18
to
ece52d5
Compare
EthanThatOneKid
approved these changes
Oct 26, 2022
|
oh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves 400 bad request error when local dev environment