-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll forward #629 #648
Merged
Merged
Roll forward #629 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored analytics library: factored out `send.ts` into `vitals.ts`. - Added env variables to pass `website_check.yaml` workflow. Addresses <#630 (comment)>. Thanks @jaasonw for kicking off this PR :)
- Refactored analytics library: factored out `send.ts` into `vitals.ts`. - Added env variables to pass `website_check.yaml` workflow. Addresses <#630 (comment)>. Thanks @jaasonw for kicking off this PR :)
EthanThatOneKid
added
bugfix
A PR that fixes a bug
HIGH PRIORITY
High priority issue, should be addressed ASAP
labels
Oct 31, 2022
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karnikaavelumani
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many changes here! Looks good to me though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #629 introduced a regression by ignoring the changes made in #630. This PR reintroduces the changes from #630.
See: https://github.com/EthanThatOneKid/acmcsuf.com/blob/2912a4122b70da872c4425035e6ad11e2f42327c/src/routes/%2Blayout.svelte