Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed
53 tasks done
OSBotify opened this issue May 25, 2023 · 10 comments
Closed
53 tasks done

Deploy Checklist: New Expensify 2023-05-25 #19565

OSBotify opened this issue May 25, 2023 · 10 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 25, 2023

Release Version: 1.3.18-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@chiragsalian
Copy link
Contributor

I think the version 1.3.18-0 was not deployed to iOS just yet. We're having some troubles with the iOS build and are working on it.

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 25, 2023
@mvtglobally
Copy link

@chiragsalian We will be starting this checklist in the morning EST. Will provide updates as we go

@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.18-0 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.18-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.18-1 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

Sounds great Maria. I was also able to fix the staging build for iOS so all platforms should be good to test tomorrow on staging on version 1.3.18-1.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.18-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.18-2 has been deployed to staging 🎉

@mvtglobally
Copy link

mvtglobally commented May 26, 2023

@yuwenmemon Regression is completed

PR #19503 (comment)
PR #19418 (comment)
PR #19392 is failing #19652
PR #19324 is failing on Desktop #19651. But its only failing when you use app "force offline" if you do wifi turn off, its passing. pls double check
#19293 (comment)
#19468 (comment)

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants