Fix the blue frame caused by selection prop #19293

ntdiary · 2023-05-19T15:21:24Z

Details

Fixed Issues

$ #15105
PROPOSAL: #15105 (comment)

Tests

Open a chat that has sent multiple messages.
Long press a sent message, then select Edit option.
Long press another sent message.
Check that the highlight blue frame doesn't appear on the Delete option or backdrop.

Verify that no errors appear in the JS console

Offline tests

Open a chat that has sent multiple messages.
Long press a sent message, then select Edit option.
Long press another sent message.
Check that the highlight blue frame doesn't appear on the Delete option or backdrop.

QA Steps

Open a chat that has sent multiple messages.
Long press a sent message, then select Edit option.
Long press another sent message.
Check that the highlight blue frame doesn't appear on the Delete option or backdrop.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mobile-chrome.mp4

Mobile Web - Safari

mobile-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

melvin-bot · 2023-05-21T06:46:21Z

@hayata-suenaga @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ntdiary · 2023-05-22T14:53:31Z

Hi @parasharrajat @hayata-suenaga please feel free to let me know if there are any areas for improvement in this PR. : )

parasharrajat · 2023-05-22T15:05:41Z

Yeah, I will check this in 2 hours.

hayata-suenaga

LGTM!

arielgreen · 2023-05-22T23:44:38Z

Yeah, I will check this in 2 hours.

@parasharrajat it's been 8 hours -- have you had a chance to review? Please provide an update asap.

parasharrajat · 2023-05-23T16:52:50Z

@ntdiary Can you please merge main into this?

parasharrajat · 2023-05-23T18:34:13Z

Thanks. Testing it.

parasharrajat · 2023-05-23T21:03:20Z

src/pages/home/report/ReportActionCompose.js

-                                                autoFocus={!this.props.modal.isVisible && (this.shouldFocusInputOnScreenFocus || this.isEmptyChat()) && this.props.shouldShowComposeInput}
+                                                autoFocus={this.shouldAutoFocus}


It won't change after the component is mounted. For example when this.props.modal.isVisible or this.props.shouldShowComposeInput changes.

Silly me. This is autoFocus prop it only works on mount. 🐤

parasharrajat · 2023-05-23T22:10:35Z

src/pages/home/report/ReportActionCompose.js

+                start: isMobileSafari && !this.shouldAutoFocus ? 0 : props.comment.length,
+                end: isMobileSafari && !this.shouldAutoFocus ? 0 : props.comment.length,


How does safari handles the selection when props.comment is present. Basically, a report has a draft.

After this change, even if there is a draft, the selection is 0 when the component mounts. When the user clicks the main composer input, the browser internally fires a selectionchange event, the selection will be updated based on the location clicked by the user.

Although currently the app does not have autofocus set on Safari I am asking this when we have set autofocus.

In general, only updating the selection of unfocused element will cause this issue.
autoFocus will focus the input before updating the selection, so there is no problem.

The only thing to note in the future is that when this.props.modal.willAlertModalBecomeVisible is true, autoFocus should be false.
Because at this time, although autoFocus will focus the input first, focus trap will immediately defocus the input (this is synchronous, so it is executed before updating the selection), which means that when the selection is updated later, the input is still unfocused.

parasharrajat · 2023-05-23T22:11:31Z

src/pages/home/report/ReportActionItemMessageEdit.js

            },
            isFocused: false,
            hasExceededMaxCommentLength: false,
        };
    }

+    componentDidMount() {
+        this.setState((prevState) => ({


Please add a comment explaining the reason behind doing this even though it is added on composer/

parasharrajat · 2023-05-23T22:34:59Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-05-24.at.11.02.34.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-05-24.at.11.08.26.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-05-24.at.11.50.37.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-05-24.at.11.28.15.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-05-24.at.11.10.24.PM.mov

🔲 Android / native

tt.Screen.Recording.2023-05-24.at.11.06.00.PM.mov

parasharrajat · 2023-05-24T11:28:08Z

Testing for one thing.

parasharrajat · 2023-05-24T11:45:45Z

BUG: Android: Report Composer is not focused on load when report is empty.

Steps:

Create a Dm with someone.
Open any other report.
GO back to LHN.
Reopen the newly created Chat.

Expected: Composer should be focused.

ntdiary · 2023-05-24T14:14:18Z

BUG: Android: Report Composer is not focused on load when report is empty.

@parasharrajat , I failed to reproduce the problem. Is there something wrong with my steps? 🤔

test-2.mp4

parasharrajat · 2023-05-24T16:26:58Z

Ok, Thanks. Let me recheck. I will try cache cleanup this time. I wasn't also able to reproduce this consistently.

parasharrajat · 2023-05-24T17:32:17Z

Ok, it seems to be working now. Completing the checklist.

parasharrajat · 2023-05-24T17:35:26Z

I am facing strange issues on iOS with focusing. (Not related to this issue).

when I try to edit a message when one is already in edit mode, newly edited message does not get focused.
when I try to edit a message when one is already in edit mode and focused, newly edited message does not get focused instead previous message get focused.

This is same on main.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @hayata-suenaga

🎀 👀 🎀 C+ reviewed

hayata-suenaga

LGTM

OSBotify · 2023-05-24T22:53:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-25T00:33:27Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:06:59Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T01:28:55Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.18-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mvtglobally · 2023-05-26T03:06:26Z

@ntdiary @parasharrajat @arielgreen We are not seeing blue border on Safari, but I think there was a really old KI about it.
Can you pls double check if we should log an issue here ?

Screen.Recording.2023-05-25.at.16.09.11.mov

parasharrajat · 2023-05-26T03:11:13Z

Which blue border?

yuwenmemon · 2023-05-26T03:25:35Z

Yes, I believe the whole point is that the blue border shouldn't appear? So it seems everything is working as expected

OSBotify · 2023-05-26T07:06:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ntdiary added 5 commits May 19, 2023 22:55

Fix the blue frame caused by selection prop

ba7e56b

Merge branch 'main' into fix-blue-frame

fc23a2a

make sure selection is updated after focus

5e8e8ea

typo

8ff517c

fix lint error

0779d23

ntdiary marked this pull request as ready for review May 21, 2023 06:46

ntdiary requested a review from a team as a code owner May 21, 2023 06:46

melvin-bot bot requested review from hayata-suenaga and parasharrajat and removed request for a team May 21, 2023 06:46

hayata-suenaga previously approved these changes May 22, 2023

View reviewed changes

Merge branch 'main' into fix-blue-frame

cb65358

ntdiary dismissed hayata-suenaga’s stale review via cb65358 May 23, 2023 18:30

parasharrajat reviewed May 23, 2023

View reviewed changes

add a comment

3e9e7ad

parasharrajat approved these changes May 24, 2023

View reviewed changes

hayata-suenaga approved these changes May 24, 2023

View reviewed changes

hayata-suenaga merged commit b69b1c5 into Expensify:main May 24, 2023

OSBotify mentioned this pull request May 25, 2023

Deploy Checklist: New Expensify 2023-05-25 #19565

Closed

53 tasks

melvin-bot bot mentioned this pull request May 26, 2023

[HOLD for payment 2023-06-02] [$4000] mWeb - Chat - Reopening Edit option highlights the Delete option in a blue frame #15105

Closed

6 tasks

bernhardoj mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-12-12] [$500] mWeb/Safari- Chat - Focus is in the start of the message when opening a report with a draft message #31708

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the blue frame caused by selection prop #19293

Fix the blue frame caused by selection prop #19293

ntdiary commented May 19, 2023 •

edited

Loading

melvin-bot bot commented May 21, 2023

ntdiary commented May 22, 2023

parasharrajat commented May 22, 2023

hayata-suenaga left a comment

arielgreen commented May 22, 2023

parasharrajat commented May 23, 2023

parasharrajat commented May 23, 2023

parasharrajat May 23, 2023

parasharrajat May 23, 2023

parasharrajat May 23, 2023

ntdiary May 23, 2023 •

edited

Loading

parasharrajat May 23, 2023

ntdiary May 24, 2023

parasharrajat May 23, 2023

parasharrajat commented May 23, 2023 •

edited

Loading

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023

ntdiary commented May 24, 2023

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023 •

edited

Loading

parasharrajat left a comment

hayata-suenaga left a comment

OSBotify commented May 24, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

mvtglobally commented May 26, 2023

parasharrajat commented May 26, 2023

yuwenmemon commented May 26, 2023

OSBotify commented May 26, 2023

		autoFocus={!this.props.modal.isVisible && (this.shouldFocusInputOnScreenFocus \|\| this.isEmptyChat()) && this.props.shouldShowComposeInput}
		autoFocus={this.shouldAutoFocus}

		start: isMobileSafari && !this.shouldAutoFocus ? 0 : props.comment.length,
		end: isMobileSafari && !this.shouldAutoFocus ? 0 : props.comment.length,

Fix the blue frame caused by selection prop #19293

Fix the blue frame caused by selection prop #19293

Conversation

ntdiary commented May 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 21, 2023

ntdiary commented May 22, 2023

parasharrajat commented May 22, 2023

hayata-suenaga left a comment

Choose a reason for hiding this comment

arielgreen commented May 22, 2023

parasharrajat commented May 23, 2023

parasharrajat commented May 23, 2023

parasharrajat May 23, 2023

Choose a reason for hiding this comment

parasharrajat May 23, 2023

Choose a reason for hiding this comment

parasharrajat May 23, 2023

Choose a reason for hiding this comment

ntdiary May 23, 2023 • edited Loading

Choose a reason for hiding this comment

parasharrajat May 23, 2023

Choose a reason for hiding this comment

ntdiary May 24, 2023

Choose a reason for hiding this comment

parasharrajat May 23, 2023

Choose a reason for hiding this comment

parasharrajat commented May 23, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023

ntdiary commented May 24, 2023

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023

parasharrajat commented May 24, 2023 • edited Loading

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented May 24, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

OSBotify commented May 25, 2023

mvtglobally commented May 26, 2023

parasharrajat commented May 26, 2023

yuwenmemon commented May 26, 2023

OSBotify commented May 26, 2023

ntdiary commented May 19, 2023 •

edited

Loading

ntdiary May 23, 2023 •

edited

Loading

parasharrajat commented May 23, 2023 •

edited

Loading

parasharrajat commented May 24, 2023 •

edited

Loading