-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: The transaction thread shows option to delete even for the payer #19433
Conversation
@mountiny @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWeb & DesktopScreen.Recording.2023-05-24.at.1.56.21.AM.movMobile Web - Chrome & Mobile Web - SafariScreen.Recording.2023-05-24.at.2.04.59.AM.moviOS & AndroidScreen.Recording.2023-05-24.at.2.00.52.AM.mov |
@Santhosh-Sellavel It is reproducible on desktop app and seems for moneyRequest report the header bg color isn't matched with the black color. I am not able to find this issue being reported in the channel.
|
@Pujan92 @Santhosh-Sellavel Huh, really weird I cannot repro in staging web, is this only in desktop? Can we go ahead with this PR if you can repro on main? |
We can go Ahead, as it is not caused by the PR here. If you wish we can increase the scope handle it too here. If let's follow our usual process to reporting from Expensify bugs channel |
@Pujan92 Are you happy to fix this issue in your PR for increasing the payout by $500 as increasing the scope? |
@mountiny I think the issue seems not very straightforward to me. So before proceeding and making a change in the PR, I just want to make a proposal here. What changes do you think we should make in order to solve the problem?We need to pass an extra prop called App/src/pages/home/ReportScreen.js Line 250 in 6728589
This prop we need to maintain and pass to HeaderGap component from Screenwrapper to apply dynamic bg color.App/src/components/ScreenWrapper/index.js Line 134 in 6728589
|
@mountiny I think it's better to move it to a separate issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into that, i agree it will be better in its separate issue
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.18-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.18-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.18-0 🚀
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.18-2 🚀
|
Details
Hide the threeDotsMenu when the user is a payer.
Fixed Issues
$ #19340
PROPOSAL: #19340 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-05-23.at.2.02.08.PM.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android