-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Web - Pay - Not here page opens when Gmail user Pay with Expensify #49523
Comments
Triggered auto assignment to @isabelastisser ( |
We think that this bug might be related to #wave-collect - Release 1 |
@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at 2024-09-20 11:10:39 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Pay - Not here page opens when gmail user Pay with Expensify What is the root cause of that problem?When user is not validated and navigates to
What changes do you think we should make in order to solve the problem?We should check if the user is validated first before we display pay with expensify button here. And hide the button when the user is not validated
What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~021837168425885571920 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 ( |
@davidcardoza, I can't add this issue to the |
Not able to reproduce! |
Edited by proposal-police: This proposal was edited at 2024-09-20 18:01:01 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Not here page appears for New Unvalidated Accounts when they try to Pay someone using expensify. What is the root cause of that problem?
We do not allow unvalidated accounts to add bank account, hence when a unvalidated user is navigated to the page, he sees a not found page:
What changes do you think we should make in order to solve the problem?Like we have for We can do the same here, when the user clicks A sample mock is as follows: I used the existing What alternative solutions did you explore? (Optional) |
Updated ProposalUpdated the proposal to add mock of the changes needed for the PR |
ProposalPlease re-state the problem that we are trying to solve in this issue.When New Unvalidated Accounts attempt to pay someone via Expensify, the Not Here page shows. What is the root cause of that problem?TriggerKYCF is triggered when an unverified user clicks "Pay with Expensify". This function will navigate to the '/settings/wallet/add-bank-account' URL (AddPersonalBankAccountPage) App/src/components/SettlementButton/index.tsx Lines 184 to 188 in 513e6b3
After navigating to AddPersonalBankAccountPage, If the user isn't validated, we show a not found page
What changes do you think we should make in order to solve the problem?In this PR, we have created a new page, which we will access whenever an unauthenticated user performs an action that necessitates authenticating their account. I believe we can apply the same strategy to this bug as well. App/src/components/SettlementButton/index.tsx Line 184 in 513e6b3
What alternative solutions did you explore? (Optional) |
This comment was marked as outdated.
This comment was marked as outdated.
🎉 Thanks everybody for the proposals and great variety in solutions! From reviewing the existing proposals, three variants are surfacing (see below) and I'm not sure whether this is a design or business decision but I'll tag @Expensify/design anyways to get their take on this before assignment since the team was active recently in PR #49230. ℹ️ As reviewer, I lean towards proposal 3 because, given PR #49230, we can agree that some work was put into this flow already specifically for the case when user account is not validated yet. My second option would be proposal 2 since it's the closest to what I think will be preferred here, and we wouldn't need to HOLD if we were to go with this version.
|
Yeah I kinda wanna hear what @JmillsExpensify and @trjExpensify thinks too. I can see an argument for both 1 and 3. 2 feels weird to me |
Agree that I'd like to hear from Jason and Tom, but my understanding was that Proposal 3 was how we wanted to handle all these unvalidated account situations (basically just add the validate screen to the beginning of whatever flow the user was trying to go through) so I have a strong preference for that option. |
Yep, same. Proposal 3 for the win. I'd also say let's make sure that copy gives them a hint to go check their mail to grab the magic code we just fired off. I.e "This feature requires you to validate your account. Enter the magic code sent to your email." |
@ikevin127, are we ready to proceed? |
Based on the latest discussions looks like @cretadn22's proposal is the way to go here. The RCA is correct and the proposed solution was verified by the design team. Note: Even though we assign the contributor now, we should HOLD #49230 until the PR is merged since the proposed solution is dependent on that PRs additions. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): gocemate+a2207@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Add bank account page should open
Actual Result:
Not here page opens when Gmail user Pay with Expensify
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6609354_1726782468479.Recording__3967.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @ikevin127The text was updated successfully, but these errors were encountered: