-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: requires validate when opening bank account #49230
base: main
Are you sure you want to change the base?
Conversation
@hungvu193 I used the App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx Lines 131 to 137 in 8d19726
I see that in other places, we show the error after the modal is closed, but why don't we show the error directly in the form, so the user don't have to open the modal again? |
Yeah, we have a plan to change that behavior in here, we should clear the error when modal is closed. |
@jjcoffee According to #49230 (comment), should we hold until #49270 is resolved until we can continue on this one? cc @hungvu193 |
@jjcoffee I tried using |
@daledah Following the flow |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2024-09-19_14.15.23.mp4Android: mWeb Chromeandroid-chrome-2024-09-19_14.17.18.mp4iOS: Nativeios-app-2024-09-19_14.01.39.mp4iOS: mWeb Safariios-safari-2024-09-19_13.55.34.mp4MacOS: Chrome / Safaridesktop-chrome-2024-09-19_14.04.03.mp4MacOS: Desktopdesktop-app-2024-09-19_14.12.43.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
Tagging @Expensify/design to take a look! Do we need to tag anyone else to review the copy? |
Minor bug: Refreshing after opening the validate modal via desktop-chrome-enable-wallet-2024-09-19_14.29.11.mp4 |
@@ -52,7 +53,7 @@ function AddPersonalBankAccountPage({personalBankAccount, plaidData}: AddPersona | |||
} else if (shouldContinue && onSuccessFallbackRoute) { | |||
PaymentMethods.continueSetup(onSuccessFallbackRoute); | |||
} else { | |||
Navigation.goBack(); | |||
Navigation.navigate(ROUTES.SETTINGS_WALLET); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this change, can you explain?
Looks pretty good to me 👍 |
Could have sworn I saw @dannymcclain leave some feedback in another PR that we could use some more spacing between the inputs and the "Didn't receive a code?" line: Does that sound right? |
@jjcoffee I think the behavior in #49230 (comment) is expected, when we reload the page, the following logic is triggered, as App/src/libs/Navigation/Navigation.ts Lines 226 to 229 in 6510ae4
|
@daledah Hmm it doesn't happen when tapping |
@jjcoffee Can you share a screenshot for this? For me both places has the same behavior: The screen navigates to wallet page after a reload. |
@daledah Ah yeah sorry I think I got confused with something else - the |
Yes I did indeed! I think a gap of |
Yeah that looks great! I agree, let's do that. |
Agree bottom positioning of the button looks better :) |
@shawnborton I updated, looks pretty good now. |
That looks good to me. If @dannymcclain gives it the thumbs up, then I think we're good here |
This comment was marked as off-topic.
This comment was marked as off-topic.
@daledah Is this issue resolved? |
@jjcoffee I updated. Almost forgot about that! Thanks for the reminder! Screen.Recording.2024-09-24.at.19.20.10.mov |
@daledah Thanks! There's still a brief flash of the first step however, anything you can do about that? |
@jjcoffee I don't think we can work around this, as the logic uses asynchronous Onyx data to display components. Maybe we can delay the action, so the steps will show up a little bit later, like this: Screen.Recording.2024-09-25.at.11.57.34.movWhat do you think? |
@jjcoffee #49230 (comment) This happens in wallet page even without opening the RHP, which caused by Screen.Recording.2024-09-25.at.12.14.48.mov |
Hmm, testing locally I actually don't see the brief flash. I guess we could also just immediately load the validation page when tapping |
Details
Fixed Issues
$ #48041
PROPOSAL: #48041 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-18.at.18.10.51.mov
Android: mWeb Chrome
Screen.Recording.2024-09-18.at.18.12.56.mov
iOS: Native
Screen.Recording.2024-09-18.at.23.29.02.mov
iOS: mWeb Safari
Screen.Recording.2024-09-18.at.23.30.55.mov
MacOS: Chrome / Safari
Screen.Recording.2024-09-18.at.17.48.10.mov
MacOS: Desktop
Screen.Recording.2024-09-18.at.23.31.26.mov