Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode binary strings in nxdl_utils.py #283

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

rettigl
Copy link
Collaborator

@rettigl rettigl commented Sep 10, 2024

No description provided.

Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that this byte array case is not checked anywhere in nxdl_utils, but for now it is fine to only check it here (if this is the part where it breaks).

dev_tools/utils/nxdl_utils.py Outdated Show resolved Hide resolved
Copy link

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit 7f0c0c8 into fairmat Sep 11, 2024
7 checks passed
@lukaspie lukaspie deleted the convert_binary_strings branch September 11, 2024 12:38
@mkuehbach
Copy link
Collaborator

https://github.com/FAIRmat-NFDI/pynxtools-em/blob/main/src/pynxtools_em/utils/hfive_utils.py L66 following is a generic implementation dealing with the 12 different string formatting strategies in HDF5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants