Enhanced binary strings decoding #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
force-pushed
the
convert_binary_strings_enhanced
branch
from
67eee90
to
5cd9dd1
Compare
rettigl
reviewed
Sep 12, 2024
src/pynxtools/nexus/nexus.py
Outdated
Comment on lines
56
to
59
| if not isinstance(string_obj, (np.ndarray, bytes, str)): | ||
| raise ValueError( | ||
| f"Unsupported type {type(string_obj)}. Expected np.ndarray, bytes, or str." | ||
| ) |
There was a problem hiding this comment.
This does not work simply like this, because I fed every value through the decode function before, i.e. also numerical ones.
There was a problem hiding this comment.
removed the type checking, now the decoding only happens on
- bytes objects -> returns list
- list of bytes or mixed bytes/str -> returns list of str
- np.arrays of of bytes or mixed bytes/str -> returns np.arrays of str
lukaspie
commented
Sep 12, 2024
sanbrock
reviewed
Sep 12, 2024
sanbrock
reviewed
Sep 12, 2024
mkuehbach
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on discussions in FAIRmat-NFDI/nexus_definitions#283 (comment)