Fix concept requirements #2513
Merged
Fix concept requirements #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
reviewed
Jan 23, 2023
cpp/dolfinx/fem/utils.h
Outdated
| @@ -769,7 +770,8 @@ void pack_coefficients(const Form<T>& form, IntegralType integral_type, int id, | |||
| { | |||
| case IntegralType::cell: | |||
| { | |||
| auto fetch_cell = [](auto& entity) { return entity.front(); }; | |||
| auto fetch_cell | |||
There was a problem hiding this comment.
Are the changes removing auto intended?
There was a problem hiding this comment.
It wasn't compiling. I think because auto& is wrong, but auto seems OK.
There was a problem hiding this comment.
I'm not sure it's wrong.
Have you checked performance? This is a critical part of the code - is the pass by value an issue?
There was a problem hiding this comment.
Not an issue for std::span
There was a problem hiding this comment.
Did you test? It brings in a copy of the size at every call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gcc-12 is showing warnings about "requires" statements, which this fixes.
See Issue #2507