Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update computation of number of components for arbitrary value shape in xdmf_function #2848

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

IgorBaratta
Copy link
Member

Fixes #2843

Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small suggestion.

cpp/dolfinx/io/xdmf_function.cpp Outdated Show resolved Hide resolved
@garth-wells garth-wells changed the title Update computation of number of components for arbitrary value shape in xdmf_function Update computation of number of components for arbitrary value shape in xdmf_function Nov 2, 2023
@garth-wells garth-wells added the bug Something isn't working label Nov 2, 2023
@garth-wells garth-wells added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit ec31042 Nov 2, 2023
20 checks passed
@garth-wells garth-wells deleted the igor/tensor_xdmf branch November 2, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Failure to write tensor valued function with non standard value shape to xdmf file
3 participants