Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pilosa Homebrew package does not include WebUI #27

Closed
codysoyland opened this issue Jun 12, 2017 · 2 comments
Closed

Pilosa Homebrew package does not include WebUI #27

codysoyland opened this issue Jun 12, 2017 · 2 comments
Assignees
@codysoyland

Comments

@codysoyland
Copy link
Contributor

codysoyland commented Jun 12, 2017 •
edited
Loading

The Homebrew package does not use the Makefile to build Pilosa, so some things get missed:

  • WebUI not built (go generate)
  • version number
  • build time

Also, the homebrew test exec "#{bin}/pilosa", "server", "--bind", "10101" is not correct, as it binds to a hostname ("10101") instead of a port (":10101"). We should remove the --bind argument as the default works.
@codysoyland
Copy link
Contributor Author

I uploaded a patch for the version number and build time in the homebrew-core repo. In order for the WebUI to work, we will need to create a homebrew package for statik (or alternative static compilation library), make it a dependency of the pilosa package, and add make generate-statik as a build step.

@codysoyland codysoyland changed the title Pilosa Homebrew package does not include WebUI, version number, and build time Pilosa Homebrew package does not include WebUI Jun 21, 2017
codysoyland added a commit to codysoyland/homebrew-core that referenced this issue Jul 5, 2017
@codysoyland
pilosa: fix missing WebUI
b9b35fb 
This adds a build step that embeds static media assets for the Pilosa WebUI
(FeatureBaseDB/general#27).
@codysoyland codysoyland mentioned this issue Jul 5, 2017
Closed
4 tasks
@codysoyland
Copy link
Contributor Author

This is in review at Homebrew/homebrew-core#15311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codysoyland codysoyland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pilosa: Add build step that generates static media assets for WebUI codysoyland/homebrew-core
1 participant
@codysoyland