pilosa: Fix version and time params and brew test #14532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build parameters for Version and BuildTime were not being passed in correctly, so the built binary did not contain the version number. Also, the command invocation used in `brew test` passed an invalid `--bind` option that wasn't caught by the test. This patch uses the Makefile to run the build command, which correctly sets the version and build time, and it removes the invalid `--bind` option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build parameters for Version and BuildTime were not being passed in
correctly, so the built binary did not contain the version number. Also,
the command invocation used in
brew testpassed an invalid--bindoption that wasn't caught by the test.
This patch uses the Makefile to run the build command, which correctly
sets the version and build time, and it removes the invalid
--bindoption.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?