Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing None explicitly to pygmt functions Part 2 #1862

Merged
merged 10 commits into from
Apr 5, 2022

Conversation

maxrjones
Copy link
Member

Description of proposed changes

Second part of #1857 following checklist in #1857 (comment), which allows passing None as arguments to pygmt functions:

  • nearneighbor
  • sphdistance
  • sphinterpolate
  • surface
  • text
  • xyz2grd

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@maxrjones maxrjones added the bug Something isn't working label Apr 1, 2022
@maxrjones maxrjones changed the title Allow passing None explicitly to pygmt functions Part 1 Allow passing None explicitly to pygmt functions Part 2 Apr 1, 2022
@maxrjones maxrjones changed the title Allow passing None explicitly to pygmt functions Part 2 WIP: Allow passing None explicitly to pygmt functions Part 2 Apr 1, 2022
@maxrjones maxrjones marked this pull request as draft April 1, 2022 15:46
@maxrjones maxrjones changed the title WIP: Allow passing None explicitly to pygmt functions Part 2 Allow passing None explicitly to pygmt functions Part 2 Apr 4, 2022
@maxrjones maxrjones marked this pull request as ready for review April 4, 2022 19:08
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Apr 4, 2022
@weiji14 weiji14 mentioned this pull request Apr 4, 2022
30 tasks
@seisman seisman merged commit 6ee851b into main Apr 5, 2022
@seisman seisman deleted the arg_is_not_None_Part2 branch April 5, 2022 10:27
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants