Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dimfilter to follow the new coding conventions #1915

Merged
merged 1 commit into from
May 6, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented May 4, 2022

Description of proposed changes

This PR updates the dimfilter function to follow the new coding conventions in #1837 and #1862.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman requested a review from willschlitzer May 4, 2022 07:46
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels May 4, 2022
@seisman seisman added this to the 0.7.0 milestone May 4, 2022
@willschlitzer willschlitzer added the final review call This PR requires final review and approval from a second reviewer label May 5, 2022
@seisman seisman merged commit 330de2d into main May 6, 2022
@seisman seisman deleted the refactor-dimfilter branch May 6, 2022 05:39
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants