Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using COPY --from, do not exclude files from dockerignore #1312

Conversation

pieterlexis
Copy link

Relates to (and quite possibly fixes) #552 and #1280.

Description
When using COPY --from to copy files from one stage to another, kaniko excludes files that are specified in the .dockerignore. This is not how COPY --from works when using docker build or podman build.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- Kaniko no longer ignores files specified in `.dockerignore` when copying files from other stages using `COPY --from`

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA not signed by all commit authors label Jun 11, 2020
@tejal29
Copy link
Member

tejal29 commented Jun 13, 2020

@pieterlexis Can you please sign the CLA.

@pieterlexis
Copy link
Author

@pieterlexis Can you please sign the CLA.

I would, but because this was written in company-time, the legal department wants to read it first 🙄

@chmaltsp
Copy link

Would love to get this in!

@tejal29
Copy link
Member

tejal29 commented Jul 28, 2020

@pieterlexis are you ok with signing the CLA?

@tejal29
Copy link
Member

tejal29 commented Aug 13, 2020

@pierrelouisb and or @chmaltsp would you be up for taking this forward?

@pieterlexis
Copy link
Author

The CLA might take some time (or will never happen) 🤷‍♂️. If someone with a CLA could pick up this PR, fix the tests and open a new PR, that would be grand!

@@ -2,4 +2,4 @@ FROM scratch as src
COPY . /

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

بروزرسانی سیستم عامل آندروید به چه طریقی هست

@Amirnateghi1
Copy link

#1312

Copy link

@Amirnateghi1 Amirnateghi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

بروزرسانی سیستم عامل آندروید شود

@@ -2,4 +2,4 @@ FROM scratch as src
COPY . /

FROM scratch as dest
COPY --from=source / .
COPY --from=src / .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Dua-l22 1.0.0.183 (c185)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no CLA not signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants