-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using COPY --from
, do not exclude files from dockerignore
#1312
When using COPY --from
, do not exclude files from dockerignore
#1312
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@pieterlexis Can you please sign the CLA. |
I would, but because this was written in company-time, the legal department wants to read it first 🙄 |
Would love to get this in! |
@pieterlexis are you ok with signing the CLA? |
@pierrelouisb and or @chmaltsp would you be up for taking this forward? |
The CLA might take some time (or will never happen) 🤷♂️. If someone with a CLA could pick up this PR, fix the tests and open a new PR, that would be grand! |
@@ -2,4 +2,4 @@ FROM scratch as src | |||
COPY . / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
بروزرسانی سیستم عامل آندروید به چه طریقی هست
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
بروزرسانی سیستم عامل آندروید شود
@@ -2,4 +2,4 @@ FROM scratch as src | |||
COPY . / | |||
|
|||
FROM scratch as dest | |||
COPY --from=source / . | |||
COPY --from=src / . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Dua-l22 1.0.0.183 (c185)
Relates to (and quite possibly fixes) #552 and #1280.
Description
When using
COPY --from
to copy files from one stage to another, kaniko excludes files that are specified in the.dockerignore
. This is not howCOPY --from
works when usingdocker build
orpodman build
.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes