fix: exclusion files during COPY statement

[alex1989hu]

Relates to (and quite possibly fixes) #552 and #1280.

Description

The original PR is here: #1312

When using COPY --from, do not exclude files from
dockerignore

Credites goes to Pieter Lexis (@pieterlexis)

Signed-off-by: Alex Szakaly alex.szakaly@gmail.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Kaniko no longer ignores files specified in `.dockerignore` when copying files from other stages using `COPY --from`

[alex1989hu]

CI failures:

• the new test integration/dockerfiles/Dockerfile_test_dont_ignore_copy_from causing no space left on device also on my machine. If I remove that new test, then no more issue with space. Thoughts?
• build-image-and-k8s-integration-test: Abuse detection of GitHub, retry possibly solves

[tejal29]

Thanks @alex1989hu. i will retry the runs.

[tejal29]

i think this '.' is causing the no space left error.

Can yo instead re-write the existing test Dockerfile_test_dockerignore

# This dockerfile makes sure the .dockerignore is working
# If so then ignore/foo should copy to /foo
# If not, then this image won't build because it will attempt to copy three files to /foo.txt, which is a file not a directory
FROM scratch as base
COPY ignore/* /foo.txt

From base as first
COPY --from=base /foo.txt ignore/bar

# Make sure that .dockerignore also applies for later stages
FROM scratch as base2
COPY ignore/* /foo.txt

From base2 as second
COPY --from=base2 /foo.txt ignore/bar

FROM scratch
# Test make sure, dockerignore is not applied with `-from`
COPY --from=first ignore/* /fooAnother/
COPY --from=second ignore/* /fooAnother2/

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tejal29]

@googlebot I consent

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[tscni]

Didn't I already fix this with #1447 where the excludes are now part of the FileContext?
For a --from COPY the FileContext is simply created without any excludes and the whole ignoreExcludes logic shouldn't be necessary at all.

Or more specifically, didn't #1234 already fix this? Which made #1447 necessary for some unrelated fixes?

[kvaps]

This PR probably solving the same issue, I solved in #1724

However I think my solutions might be better as it not even saving the ignored files into cached layer, take a look at this:
f7fc5c3#diff-1e90758e2fb0f26bdbfe7a40aafc4b4796cbf808842703e52e16c1f36b8da7dc