Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying root #1724

Closed
wants to merge 3 commits into from
Closed

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Aug 19, 2021

Fixes #960

Description

This PR updates otiai10/copy module from v1.0.2 to v1.6.0.
Adds option to not copying ignored paths for CopyFileOrSymlink which solves two problems at once:

  • Allows copying root (/)
  • Avoid leaking docker credentials using COPY command while building the image.

It might need rebase after merging #1725.
This branch includes both fixes: kvaps:fix-copying-root-and-ownership; compiled docker images:

ghcr.io/kvaps/kaniko-executor:v1.6.0-fix
ghcr.io/kvaps/kaniko-executor:v1.6.0-fix-debug
ghcr.io/kvaps/kaniko-warmer:v1.6.0-fix

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Add additional check for ignored files on COPY
- Support copying root (`/`) of image

@google-cla google-cla bot added the cla: yes CLA signed by all commit authors label Aug 19, 2021
@kvaps kvaps mentioned this pull request Aug 19, 2021
4 tasks
@kvaps kvaps changed the title fix: copying root (#960) Fix copying root Aug 19, 2021
@kvaps kvaps force-pushed the fix-copying-root branch 5 times, most recently from 2ce34ef to a5d2d8d Compare August 20, 2021 11:04
@ghost ghost mentioned this pull request Oct 7, 2021
@kvaps
Copy link
Contributor Author

kvaps commented Nov 2, 2021

PR rebased to v1.7.0, new docker images with this change prepared:

ghcr.io/kvaps/kaniko-executor:v1.7.0
ghcr.io/kvaps/kaniko-executor:v1.7.0-debug
ghcr.io/kvaps/kaniko-warmer:v1.7.0

source code of fork in master branch:
https://github.com/kvaps/kaniko/

@kvaps kvaps force-pushed the fix-copying-root branch 8 times, most recently from 161fe20 to d10130b Compare December 26, 2021 12:33
@imjasonh imjasonh self-assigned this Dec 26, 2021
@kvaps kvaps force-pushed the fix-copying-root branch 3 times, most recently from 02bcf48 to 63062c7 Compare December 26, 2021 14:16
@kvaps kvaps force-pushed the fix-copying-root branch 2 times, most recently from 2295366 to 607036e Compare December 26, 2021 14:37
@kvaps kvaps force-pushed the fix-copying-root branch 3 times, most recently from a108d28 to a509373 Compare December 26, 2021 23:31
@jasondamour
Copy link
Contributor

@kvaps any movement on this? Do you need help w last mile?

@aaron-prindle
Copy link
Collaborator

@kvaps would you be able to rebase the PR here? Would like to get this in if possible, thanks!

@aaron-prindle
Copy link
Collaborator

aaron-prindle commented Jun 20, 2023

Submitted this PR here #2592 which rebases the changes here. Closing and moving the conversation over that PR. Feel free to re-submit, re-open, discuss, etc. if you would like to own this going in - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko is stucking on copying root
5 participants