feat: alter logical region in metric region #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2726 +/- ##
===========================================
- Coverage 85.22% 85.00% -0.22%
===========================================
Files 765 765
Lines 123909 124743 +834
===========================================
+ Hits 105603 106040 +437
- Misses 18306 18703 +397 |
fengjiachun
reviewed
Nov 13, 2023
killme2008
reviewed
Nov 13, 2023
Co-authored-by: dennis zhuang <killme2008@gmail.com> Co-authored-by: JeremyHi <jiachun_feng@proton.me>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
killme2008
approved these changes
Nov 14, 2023
Co-authored-by: dennis zhuang <killme2008@gmail.com>
fengjiachun
approved these changes
Nov 15, 2023
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
25 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support to alter logical region. And
A spectre is haunting in my mind -- the spectre of Table Engine. Some Powers of this PR have entered into a holy alliance to exorcise this spectre
Checklist
Refer to a related PR or issue link (optional)
#2070