Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: alter logical region in metric region #2726

Merged
merged 8 commits into from
Nov 15, 2023
Merged

feat: alter logical region in metric region #2726

merged 8 commits into from
Nov 15, 2023

Commits on Nov 9, 2023

  1. add test for add and alter logical region 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    331b9b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. remove table id 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f621f22 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Apply suggestions from code review 

    Co-authored-by: dennis zhuang <killme2008@gmail.com>
Co-authored-by: JeremyHi <jiachun_feng@proton.me>
    @waynexia @killme2008 @fengjiachun
    3 people committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3da48be View commit details
    Browse the repository at this point in the history

  2. CR sugg. 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    39accec View commit details
    Browse the repository at this point in the history

  3. extract internal states into a struct 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e6fb4cd View commit details
    Browse the repository at this point in the history

  4. remove unused deps 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    7e51782 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Apply suggestions from code review 

    Co-authored-by: dennis zhuang <killme2008@gmail.com>
    @waynexia @killme2008
    waynexia and killme2008 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ca8bf89 View commit details
    Browse the repository at this point in the history

  2. tweak fn name 

    Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
    @waynexia
    waynexia committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ba98f7b View commit details
    Browse the repository at this point in the history