Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailhog is not truly building 0.2.0 version #2501

Closed
3 tasks done
swrobel opened this issue Jun 29, 2016 · 8 comments
Closed
3 tasks done

mailhog is not truly building 0.2.0 version #2501

swrobel opened this issue Jun 29, 2016 · 8 comments
Labels
go Go use is a significant feature of the PR or issue

Comments

@swrobel
Copy link
Sponsor Contributor

swrobel commented Jun 29, 2016

Please follow the general troubleshooting steps first:

  • Ran brew update and retried your prior step?
  • Ran brew doctor, fixed as many issues as possible and retried your prior step?
  • If you're seeing permission errors tried running sudo chown -R $(whoami) $(brew --prefix)?

You can erase any parts of this template not applicable to your Issue.

Bug reports:

The mailhog formula downloads the correct 0.2.0 version of the archive from github, but then downloading outdated versions of the deps, such as Mailhog, Mailhog-UI and Mailhog-Server.

I would submit a PR to update these, but:

  1. I'm not very familiar with the Go build process
  2. I'm not sure what @maijs's rationale was for locking to these specific versions, especially when it comes to external deps (it seems obvious to me that the Mailhog ones should be locked to their respective version tags)
@dunn dunn added the go Go use is a significant feature of the PR or issue label Jul 3, 2016
@dunn
Copy link
Contributor

dunn commented Jul 3, 2016

Usually we use the latest revision of a dependency since Go often just pulls HEAD; but it looks like the dependency revisions weren't updated with the 2.0 release. So a PR to bump the revisions to either their latest or to a corresponding 0.2.0 tag would be great!

@DomT4
Copy link
Member

DomT4 commented Jul 3, 2016

I looked into this the other night & fell down a deep, deep rabbithole. It turns out we've added some dependencies as go_resources, but not all, but if you add them all it doesn't compile. It'd be really nice if upstream moved over to the vendor system here really.

@maijs
Copy link
Contributor

maijs commented Jul 5, 2016

@swrobel The specific revisions were locked because with the most recent versions of external dependencies MailHog would not build, at least at the time the formula was created.

@swrobel
Copy link
Sponsor Contributor Author

swrobel commented Jul 6, 2016

@maijs I was afraid of that. I've filed a related issue with Mailhog about the complicated build process

In the interim, how does everyone feel about using the prebuilt binaries that mailhog offers?

@maijs
Copy link
Contributor

maijs commented Jul 7, 2016

@swrobel I haven't used prebuilt binaries on a Mac, but they do work out-of-box on Ubuntu.

@swrobel
Copy link
Sponsor Contributor Author

swrobel commented Jul 7, 2016

amd64 build is working great for me on 2 separate macs

@MikeMcQuaid
Copy link
Member

We don't use prebuilt binaries in Homebrew. Could you try and open a pull request? This document should help and I'm happy to walk you through anything else.

Thanks!

@DomT4
Copy link
Member

DomT4 commented Jul 10, 2016

Given the problematic upstream build process I'd lean towards either removing from Homebrew completely, accepting the status quo with outdated resources or removing from core and moving to binary.

@DomT4 DomT4 mentioned this issue Sep 3, 2016
4 tasks
DomT4 added a commit that referenced this issue Sep 3, 2016
I cannot emphasise enough how reluctant we would be to backport this much
from upstream if the existing build wasn't completely broken in several ways.
As it happens, it's either this or the boneyard, so let's go with this.

Ref: #2931
Ref: #2501 (comment)
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

No branches or pull requests

5 participants